Pcornat/BillySheet
1
0
Fork 0
Code Issues Pull requests Releases Activity

Compare commits

base: Pcornat:62f283be0bac6b73d9f761176c2b3245e02720fb
Branches Tags
Pcornat:main
..
compare: Pcornat:698aed88604203b1dc554d191509655c5d74ae2c
Branches Tags
Pcornat:main

2 commits
62f283be0b ... 698aed8860

Author SHA1 Message Date
Pcornat
698aed8860
 		Difference in letter for different stages 2026-03-18 14:14:10 +01:00
Pcornat
85b20f8448
 		Changing materiel to a signed field. 
It can become negative.
 2026-03-18 14:13:53 +01:00
2 changed files with 9 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Unit testing/billy_objects_tests.cpp
View file

@ -112,7 +112,7 @@ TEST_CASE("[D] Deserialize full BillyObjects", "[deserialize][1]") {
REQUIRE(std::get<equipments>(dummy_object.objects.at(equipments::MedicKit)->get_type()) == equipments::MedicKit);
}
TEST_CASE("[D] Pushing popping BillyObjects", "[pushpop][0]") {
TEST_CASE("[E] Pushing popping BillyObjects", "[pushpop][0]") {
constexpr std::array<billyEnums, 12> all_objects{
weapons::Sword,
weapons::Lance,
@ -153,7 +153,7 @@ TEST_CASE("[D] Pushing popping BillyObjects", "[pushpop][0]") {
}
}
TEST_CASE("[D] Double erase no throw", "[pushpop][1]") {
TEST_CASE("[E] Double erase no throw", "[pushpop][1]") {
BillyObjects gestionnaire{};
CharacterSheet sheet;
REQUIRE(sheet.get_objects().empty());
@ -165,7 +165,7 @@ TEST_CASE("[D] Double erase no throw", "[pushpop][1]") {
REQUIRE_FALSE(gestionnaire.erase_object(sheet, weapons::Bow));
}
TEST_CASE("[D] Insert no more than 3", "[pushpop][2]") {
TEST_CASE("[E] Insert no more than 3", "[pushpop][2]") {
BillyObjects gestionnaire{};
CharacterSheet sheet;
REQUIRE(sheet.get_objects().empty());
@ -178,7 +178,7 @@ TEST_CASE("[D] Insert no more than 3", "[pushpop][2]") {
REQUIRE(sheet.get_objects().size() == 3);
}
TEST_CASE("[D] Printing Billy's objects", "[printing]") {
TEST_CASE("[F] Printing Billy's objects", "[printing]") {
for (const auto &object: BillyObjects::all_objects) {
const std::unique_ptr<GenericObject> obj = test::get_obj(object);
REQUIRE_NOTHROW(BillyObjects::billy_object_to_string(obj));

11
include/characteristic.hpp
View file

@ -12,7 +12,6 @@ namespace character {
}
namespace character::characteristic {
/*!
* \brief Different characteristic type
*/
@ -41,7 +40,7 @@ namespace character::characteristic {
std::uint32_t carac{ 0 };
//! Value changed from a billyObjects (billyEnums) possessed
std::uint32_t materiel{ 0 };
std::int32_t materiel{ 0 };
//! Additional value when creating the character
std::uint32_t additional{ 0 };
@ -70,7 +69,7 @@ namespace character::characteristic {
constexpr Characteristic(const characType inType,
const std::uint32_t carac,
const std::uint32_t materiel,
const std::int32_t materiel,
const std::uint32_t additional) :
base(get_base(inType)),
carac(carac),
@ -98,11 +97,11 @@ namespace character::characteristic {
[[nodiscard]] std::uint32_t get_carac() const { return carac; }
[[nodiscard]] std::uint32_t get_materiel() const { return materiel; }
[[nodiscard]] std::int32_t get_materiel() const { return materiel; }
[[nodiscard]] std::uint32_t get_additional() const { return additional; }
[[nodiscard]] std::size_t get_total() const noexcept {
[[nodiscard]] std::int32_t get_total() const noexcept {
if (total == defaultValue::max()) {
total = static_cast<std::int32_t>(base + carac + materiel + additional);
total = std::max(total, 0);
@ -114,7 +113,7 @@ namespace character::characteristic {
const_cast<std::uint32_t &>(charac.base) = j.at("base").get<std::uint32_t>();
const_cast<characType &>(charac.type) = static_cast<characType>(j.at("type").get<std::uint8_t>());
charac.carac = j.at("carac").get<std::uint32_t>();
charac.materiel = j.at("materiel").get<std::uint32_t>();
charac.materiel = j.at("materiel").get<std::int32_t>();
charac.additional = j.at("additional").get<std::uint32_t>();
charac.total = j.at("total").get<std::int32_t>();
}