From 3e37df5fc21a49678a0e89008783552f3d3945de Mon Sep 17 00:00:00 2001 From: Pcornat Date: Fri, 27 Feb 2026 22:54:43 +0100 Subject: [PATCH 1/3] Remove useless namespace usage --- src/generic_object.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/generic_object.cpp b/src/generic_object.cpp index 70fd557..0679352 100644 --- a/src/generic_object.cpp +++ b/src/generic_object.cpp @@ -31,7 +31,7 @@ namespace character { std::uint32_t Weapons::add_damage() const noexcept { return type == weapons::Morgenstern ? 1 : 0; } - std::int32_t Weapons::add_materiel(const characteristic::characType &inType) const noexcept { + std::int32_t Weapons::add_materiel(const characType &inType) const noexcept { switch (type) { case weapons::Sword: if (inType == characType::Habilete) { @@ -94,7 +94,7 @@ namespace character { std::uint32_t Equipments::add_damage() const noexcept { return 0; } - std::int32_t Equipments::add_materiel(const characteristic::characType &inType) const noexcept { + std::int32_t Equipments::add_materiel(const characType &inType) const noexcept { switch (type) { case equipments::Chainmail: if (inType == characType::Habilete || @@ -130,7 +130,7 @@ namespace character { std::uint32_t Tools::add_damage() const noexcept { return 0; } - std::int32_t Tools::add_materiel(const characteristic::characType &inType) const noexcept { + std::int32_t Tools::add_materiel(const characType &inType) const noexcept { switch (type) { case tools::Fourche: switch (inType) { From 7c6a529e14dd6666cb32f688aaa42875e09b1aa4 Mon Sep 17 00:00:00 2001 From: Pcornat Date: Fri, 27 Feb 2026 22:54:51 +0100 Subject: [PATCH 2/3] Add EOL in file --- src/generic_object.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/generic_object.cpp b/src/generic_object.cpp index 0679352..7ce6588 100644 --- a/src/generic_object.cpp +++ b/src/generic_object.cpp @@ -166,4 +166,4 @@ namespace character { return sackOfGrain; } } -} \ No newline at end of file +} From 04f876dc4f1edeb3d88f9c2192002d1758dc9d3d Mon Sep 17 00:00:00 2001 From: Pcornat Date: Fri, 27 Feb 2026 22:57:42 +0100 Subject: [PATCH 3/3] Same C++ version for unit tests --- Unit testing/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Unit testing/CMakeLists.txt b/Unit testing/CMakeLists.txt index 2b91628..cf47abc 100644 --- a/Unit testing/CMakeLists.txt +++ b/Unit testing/CMakeLists.txt @@ -12,7 +12,7 @@ add_executable(UnitTest ) set_target_properties(Catch2 UnitTest PROPERTIES - CXX_STANDARD 17 + CXX_STANDARD 23 CXX_STANDARD_REQUIRED ON CXX_EXTENSIONS OFF INTERPROCEDURAL_OPTIMIZATION_RELEASE ON